Skip to content

Multi-root workspace prompts twice for cwd selection #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks done
andyleejordan opened this issue Jul 29, 2022 · 1 comment · Fixed by #4099
Closed
6 tasks done

Multi-root workspace prompts twice for cwd selection #4098

andyleejordan opened this issue Jul 29, 2022 · 1 comment · Fixed by #4099
Assignees
@andyleejordan
Labels
Area-Workspaces Issue-Bug A bug to squash.

Comments

@andyleejordan
Copy link
Member

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

Thought I'd already fixed this, but sadly it made into stable. If you use multi-root workspaces with the PowerShell extension, please react to this issue so I know how to prioritize this and the remaining work for full support of it!

PowerShell Version

7.2.5

Visual Studio Code Version

1.69.2

Extension Version

v2022.7.2

Steps to Reproduce

Open a multi-root workspace without cwd set. Choose which folder in the prompt, then sadly it prompts again.

Visuals

No response

Logs

No response
@andyleejordan andyleejordan added the Issue-Bug A bug to squash. label Jul 29, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Jul 29, 2022
@andyleejordan andyleejordan self-assigned this Jul 29, 2022
@andyleejordan andyleejordan added Area-Workspaces and removed Needs: Triage Maintainer attention needed! labels Jul 29, 2022
@andyleejordan
Copy link
Member Author

Other work: #3796 and the issue #2153.

@andyleejordan andyleejordan mentioned this issue Jul 29, 2022
Merged
Repository owner moved this from Todo to Done in American Pharoah Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-Workspaces Issue-Bug A bug to squash.
Projects
No open projects
American Pharoah
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix checkIfDirectoryExists() so validateCwdSetting() works PowerShell/vscode-powershell
1 participant
@andyleejordan