Skip to content

Avoid using workspace.rootPath #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roblourens opened this issue Aug 24, 2019 · 2 comments · Fixed by #3796
Closed

Avoid using workspace.rootPath #2153

roblourens opened this issue Aug 24, 2019 · 2 comments · Fixed by #3796
Assignees
@andyleejordan
Labels
Area-Workspaces Issue-Enhancement A feature request (enhancement).

Comments

@roblourens
Copy link

workspace.rootPath is a deprecated property and may not work as expected. Please use workspaceFolders instead. More info: https://github.com/microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs#eliminating-rootpath

microsoft/vscode#69335
@ghost ghost added the Needs: Triage Maintainer attention needed! label Aug 24, 2019
@SydneyhSmith SydneyhSmith added Area-Workspaces Issue-Enhancement A feature request (enhancement). and removed Needs: Triage Maintainer attention needed! labels Aug 26, 2019
@SydneyhSmith SydneyhSmith mentioned this issue Mar 24, 2020
Closed
@SydneyhSmith SydneyhSmith mentioned this issue Apr 9, 2020
Closed
@markm77
Copy link

markm77 commented Apr 10, 2020 •
edited
Loading

Yes, just want to echo that integrated console is opening in root of first (unrelated) project rather than root of project containing script in a multi-root workspace. Which is not desirable but understand you are tracking this.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Apr 10, 2020
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Apr 10, 2020
@TylerLeonhardt
Copy link
Member

The problem is, the extension has been working with the assumption that there's one root for so long that switching to mult-root is non-trivial unfortunately.. but we do want to support this.

@andyleejordan andyleejordan added this to the Consider-vNext milestone Jan 28, 2022
@andyleejordan andyleejordan mentioned this issue Jan 28, 2022
Merged
@andyleejordan andyleejordan mentioned this issue Feb 28, 2022
Closed
4 tasks
@andyleejordan andyleejordan changed the title Avoid using workspace.rootPath Avoid using workspace.rootPath Feb 28, 2022
@andyleejordan andyleejordan moved this from Todo to In Progress in American Pharoah Apr 19, 2022
@SydneyhSmith SydneyhSmith moved this from P0- In Progress to P1 - in Progress in American Pharoah May 3, 2022
@andyleejordan andyleejordan mentioned this issue Jul 7, 2022
Merged
@andyleejordan andyleejordan mentioned this issue Jul 29, 2022
Closed
6 tasks
@SydneyhSmith SydneyhSmith removed this from the Consider-vNext milestone Aug 11, 2022
@andyleejordan andyleejordan mentioned this issue Aug 16, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-Workspaces Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fully support multi-root workspaces PowerShell/vscode-powershell
5 participants
@roblourens @andyleejordan @TylerLeonhardt @markm77 @SydneyhSmith