Skip to content

ADO Pipeline build is adding PSReadLine 2.2.0 #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyleejordan opened this issue Jun 1, 2021 · 5 comments
Closed

ADO Pipeline build is adding PSReadLine 2.2.0 #3387

andyleejordan opened this issue Jun 1, 2021 · 5 comments
Assignees
Labels

Comments

@andyleejordan
Copy link
Member

We've verified that the ADO Pipeline for PowerShellEditorServices correctly brings PSReadLine 2.1.0 in, but then found that 2.2.0 is bundled alongside it in the built VSIX. This is bizarre, and part of the cause of #3384 and #3385. Our build should not be downloading another PSReadLine. We are going to patch the 2021.5.1 release, and then fix this for the next release.

@andyleejordan andyleejordan added this to the Committed-vNext milestone Jun 1, 2021
@andyleejordan andyleejordan self-assigned this Jun 1, 2021
@andyleejordan
Copy link
Member Author

The consumed PowerShellEditorServices build is publishing correct artifacts:
Screen Shot 2021-06-01 at 3 06 46 PM

@andyleejordan
Copy link
Member Author

Interesting...recent build in ADO seems to no longer do this.

@andyleejordan
Copy link
Member Author

I haven't seen this happen again. I almost suspect we maybe didn't see it the first time? I don't know. Anyway, it's something to be on the lookout for, but I'm resolving this.

@andyleejordan andyleejordan added Resolution-Fixed Will close automatically. and removed Resolution-Fixed Will close automatically. labels Jun 17, 2021
@andyleejordan
Copy link
Member Author

Actually, I think we should resolve this by an addition to the build script that essentially tests the built output to be sure this doesn't repro.

@andyleejordan
Copy link
Member Author

I haven't seen this repro once since, and we've gone ahead and fixed PSES to only load the bundled PSReadLine. So I'm not sure if we should keep this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant