-
Notifications
You must be signed in to change notification settings - Fork 510
VS Code + PowerShell 7 from the Store Broken #3384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is due to your machine having an incompatible version of PSReadLine 2.2.0-beta2. It is curious, as far as I'm aware that issue should only occur with the latest PowerShell 7 preview 7.2.0-preview.6 and you look like you have 7.1.3, but the stack trace is identical to the problem reported in #3385. Please revert PSReadLine to 2.1.0 (either just uninstall PSReadLine and let the extension use its bundled version instead, or manually revert or even upgrade to beta3). |
@rjmholt Can you help me confirm this? The store release is 7.1.3, which I would have thought was compatible with PSReadLine 2.2.0-beta2, but I mean check that stack trace as it flies by in the GIF. |
It's definitely in the prediction part of PSReadLine, which suggests that it's related to that. |
I downloaded that GIF and stepped through it frame by frame, it is the same stack trace. |
Ok we have a plan: to avoid incompatibility issues such as this and #3385 we are going to patch PowerShellEditorServices to only load our bundled version of PSReadLine. |
@daxian-dbw this is such a strange issue, it's the exact same stack trace caused by the incompatibility issue, but it's with 7.1.3; @rjmholt thinks he may know what's going on. |
2.2.0-beta2 version of PSReadLine shouldn't have this issue with 7.1.x because the affected bits only kick in when the .NET version is >= 6, while 7.1.x uses .NET 5. The logs show the path to the pwsh.exe but not the version of the powershell:
This path looks like installed from Windows Store, and it's likely 7.2.0-preview.6 |
Hey @potatoqualitee are you perhaps using "PowerShell Preview" in the store? |
So ok, this is strange, but for some reason 2.2.0 is being bundled alongside 2.1.0. |
Going to leave this closed in favor of #3387, the task to fix the build. The latest stable release is patched and only contains PSReadLine 2.1.0, effectively avoiding this problem. |
@andschwa I think I was using the PS Preview but then uninstalled it and went with the stable version and both were broken. Seems like you have the solution though, thank you! |
Issue Description
I am experiencing a problem with I'm guessing the PowerShell 7 Store.
After seeing the results in the video below, I upgraded psreadline, EditorServicesCommandSuite, I even deleted them from my system entirely from my system then reinstalled the extension so perhaps it's the versions within the extension.
I've installed/reinstalled/uninstalled powershell 7 as well as the extensions and the required modules.
This breaks on all modules.
Attached Logs
Attached
logs.zip
vscode.mp4
Environment Information
Visual Studio Code
PowerShell Information
Visual Studio Code Extensions
Visual Studio Code Extensions(Click to Expand)
The text was updated successfully, but these errors were encountered: