Skip to content

Extension must not steal focus on load #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FallenGameR opened this issue May 4, 2020 · 4 comments
Closed

Extension must not steal focus on load #2677

FallenGameR opened this issue May 4, 2020 · 4 comments
Labels
Resolution-Inactive Will close automatically.

Comments

@FallenGameR
Copy link

Summary of the new feature

When VS Code starts it loads Powershell extension if it is enabled. On load it starts new terminal and terminal window pops up stealing focus. It should not do that. I want to edit the code and I want the code editor to be in the focus. Instead I have to close the terminal window every time extension is loaded. It is so annoying I tend to disable the extension altogether when I'm writing Powershell code.

Proposed technical implementation details (optional)

If you need to open terminal for the extension to work, do that in background. Or provide some option that would instruct the extension how it should start.

@ghost ghost added the Needs: Triage Maintainer attention needed! label May 4, 2020
@rkeithhill
Copy link
Contributor

There is a setting for this already:

image

When this setting is not checked, the integrated console is still created so that various editor features like completions work but the console is not shown and therefore won't steal focus.

@rjmholt rjmholt added Needs-Repro-Info and removed Needs: Triage Maintainer attention needed! labels May 4, 2020
@rjmholt
Copy link
Contributor

rjmholt commented May 4, 2020

I think there's been some discussion of the various configurable subtleties of the integrated console in other issues too. In particular, should the console:

  1. Appear and be in focus
  2. Appear but not be in focus
  3. Not pop up, but be added to the list of terminals
  4. Be completely hidden

(I may have missed some choices, and I'm not sure which are not possible today in VSCode)

So we may want to deduplicate this request to one of the other issues that discusses this; configuring for (3) or (4) may not perfectly satisfy the request for (2).

@rjmholt rjmholt added the Needs: Triage Maintainer attention needed! label May 4, 2020
@rkeithhill
Copy link
Contributor

The option I've shown above implements #4 - PSIC is completely hidden until you start a debug session. After the debug session ends, PSIC does not hide again. So yeah, there are some subtleties here that need some work. :-)

@TylerLeonhardt TylerLeonhardt removed the Needs: Triage Maintainer attention needed! label May 4, 2020
@ghost
Copy link

ghost commented May 19, 2020

This issue is being closed as inactive, if this issue is still occurring it will be re-opened

@ghost ghost added the Resolution-Inactive Will close automatically. label May 19, 2020
@ghost ghost closed this as completed May 19, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Inactive Will close automatically.
Projects
None yet
Development

No branches or pull requests

4 participants