-
Notifications
You must be signed in to change notification settings - Fork 511
Add check for OpenSSL on OS X before starting the language service #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That check on the path only works if you are using homebrew. For MacPorts:
fixes it. |
Thanks a lot @MarlonRodriguez! I'll include your fix in the troubleshooting notes. |
This change adds a check when the extension initializes to verify whether the machine has OpenSSL installed when running on OS X. This is currently a requirement of PowerShell which must be met before PowerShell Editor Services can be started. If the proper library paths are not detected, a message is shown to the user which leads them to documentation on how to install OpenSSL.
It'd be nice if a link to some instructions on how to resolve this were added to the notification as well. |
That's what the "Show Documentation" button on the notification does, did it not show up for you? |
I'm blind. Thanks but I had originally installed it. It wasn't until I openssl-1.0.2h_1 already installed On Sun, Sep 4, 2016 at 5:38 PM, David Wilson [email protected]
|
Interesting, @RamblingCookieMonster mentioned the same thing to me yesterday. If you follow the steps in the documentation page about creating symbolic links it should fix the problem for you. Quick question before you do that though: was IntelliSense working for you without a problem on OS X before the latest update? Maybe I'm checking the incorrect path for Brew's install of OpenSSL. |
@adbertram try this (probably a way to script this out, but, a bit busy, sorry!):
Example: ln -s /usr/local/Cellar/openssl/1.0.2h_1/lib/libcrypto.1.0.0.dylib /usr/local/lib/
ln -s /usr/local/Cellar/openssl/1.0.2h_1/lib/libssl.1.0.0.dylib /usr/local/lib/ Doesn't seem sustainable though, cleanups happen, and this links to a version-specific (i.e. likely temporal) file. Cheers! |
Thanks @RamblingCookieMonster! That did it. |
@daviwil Yes. This was working fine before I updated. |
Damn, so apparently my path check gave a false negative for Homebrew installs... I'll need to look into that. |
Tracking the false negative problem here: #286. Thanks Adam! |
The extension should check for the existence of OpenSSL on OS X before starting the language service. If it cannot be found, the user should be directed to the documentation which guides them through the OpenSSL installation.
One way to check for existence could be to test for the existence of
/usr/local/opt/openssl
The text was updated successfully, but these errors were encountered: