Skip to content

Extension is not working if windows username contains spaces #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Aug 18, 2016 · 7 comments
Closed

Extension is not working if windows username contains spaces #244

ghost opened this issue Aug 18, 2016 · 7 comments
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@ghost
Copy link

ghost commented Aug 18, 2016

Installed extension today for the first time and it seems like I'm the only one who got spaces in windows account. :) Basically, EditorServices couldn't be started (log attached) and I guess debugger fails for the same reason. Added local account without spaces -- everything works.

1471546041-PowerShell.txt

@daviwil
Copy link
Contributor

daviwil commented Aug 18, 2016

Ouch, I immediately see the issue. Sorry for the trouble! Will get this fixed in the next couple of days.

@daviwil daviwil added the Issue-Bug A bug to squash. label Aug 18, 2016
@daviwil daviwil added this to the 0.7.1 milestone Aug 18, 2016
@daviwil
Copy link
Contributor

daviwil commented Aug 18, 2016

The path to Start-EditorServices.ps1 needs to be enclosed with quotation marks:

powershell.exe started --
    pid: 12428
    exe: C:\WINDOWS\Sysnative\WindowsPowerShell\v1.0\powershell.exe
    bundledModulesPath: C:\Users\Maksims Prieditis\.vscode\extensions\ms-vscode.PowerShell-0.7.0\modules
    args: C:\Users\Maksims Prieditis\.vscode\extensions\ms-vscode.PowerShell-0.7.0\scripts\Start-EditorServices.ps1 -EditorServicesVersion "0.7.0" -HostName "Visual Studio Code Host" -HostProfileId "Microsoft.VSCode" -HostVersion "0.7.0" -BundledModulesPath "C:\Users\Maksims Prieditis\.vscode\extensions\ms-vscode.PowerShell-0.7.0\modules" -LogLevel "Normal" -LogPath "C:\Users\Maksims Prieditis\.vscode\extensions\ms-vscode.PowerShell-0.7.0\logs\1471546041-EditorServices.log" 

@ciberesponce
Copy link

Same issue... after about 2 hours of debugging i finally decided to check out the bugs section. Thanks for filing this, thanks for fixing this and thanks for the fix!

@daviwil
Copy link
Contributor

daviwil commented Aug 22, 2016

Hey Andrew, sorry for the trouble, I'll definitely get this fixed soon! Working on fixes for an upcoming 0.7.1 update right now.

daviwil added a commit that referenced this issue Aug 24, 2016
This change fixes #244 which reports that the extension does not load when
the user's username contains a space.  This was caused by the script
execution of Start-EditorServices.ps1 not being contained within quotes.
@daviwil daviwil mentioned this issue Aug 24, 2016
@daviwil
Copy link
Contributor

daviwil commented Aug 24, 2016

I just released an update to the extension, check it out and see if it resolve the issue for you!

@ghost
Copy link
Author

ghost commented Aug 25, 2016

It works like a charm! Thank you!

@daviwil
Copy link
Contributor

daviwil commented Aug 25, 2016

Excellent, thanks a lot for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants