Skip to content

Comment for powershell.powerShellDefaultVersion should not complete full PowerShell Core Version #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DerAlbertCom opened this issue Jan 28, 2019 · 3 comments · Fixed by #1747
Assignees
Labels

Comments

@DerAlbertCom
Copy link

In the comment for the setting

powershell.powerShellDefaultVersion is stated that the Version nummber should be given is something like PowerShell Core 6.0.2 (x64), which would be in my case PowerShell Core 6.1.2 (x64) no other version is installed.

"description": "Specifies the name of the PowerShell version used in the startup session when the extension loads e.g \"Windows PowerShell (x86)\" or \"PowerShell Core 6.0.2 (x64)\"."

But this does not work. With the full version number the Plugin falls back to PowerShell 5.1.x (Full Framework) .

But "powershell.powerShellDefaultVersion": "PowerShell Core 6 (x64)" is working fine.

I don't know what the expected behavior is, so i didn't provide a PR for that now.

@rkeithhill
Copy link
Contributor

Looks like we grab the expected version number from the path to pwsh.exe. And over time, the PS team has changed their version number strategy for that path.

@DerAlbertCom
Copy link
Author

DerAlbertCom commented Jan 28, 2019

Yes. I digged in the Source to get this information how the Version Information is created.

On my the path is C:\Program Files\PowerShell\6\pwsh.exe. That's why my version number works for me.

@SydneyhSmith
Copy link
Collaborator

Thanks for catching this @DerAlbertCom we should provide a better comment that is inclusive for all versions of PowerShell.

@rkeithhill rkeithhill self-assigned this Feb 7, 2019
rkeithhill added a commit that referenced this issue Feb 7, 2019
Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix #1734
TylerLeonhardt pushed a commit that referenced this issue Feb 8, 2019
Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix #1734
TylerLeonhardt pushed a commit to TylerLeonhardt/vscode-powershell that referenced this issue Mar 18, 2019
Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix PowerShell#1734
TylerLeonhardt pushed a commit that referenced this issue Mar 20, 2019
Update session menu "switch to" entries to more clearly distinguish the
"version name".

Fix #1734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants