-
Notifications
You must be signed in to change notification settings - Fork 511
Comment for powershell.powerShellDefaultVersion should not complete full PowerShell Core Version #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looks like we grab the expected version number from the path to pwsh.exe. And over time, the PS team has changed their version number strategy for that path. |
Yes. I digged in the Source to get this information how the Version Information is created. On my the path is |
Thanks for catching this @DerAlbertCom we should provide a better comment that is inclusive for all versions of PowerShell. |
Update session menu "switch to" entries to more clearly distinguish the "version name". Fix #1734
Update session menu "switch to" entries to more clearly distinguish the "version name". Fix #1734
Update session menu "switch to" entries to more clearly distinguish the "version name". Fix PowerShell#1734
Update session menu "switch to" entries to more clearly distinguish the "version name". Fix #1734
In the comment for the setting
powershell.powerShellDefaultVersion
is stated that the Version nummber should be given is something like PowerShell Core 6.0.2 (x64), which would be in my case PowerShell Core 6.1.2 (x64) no other version is installed.vscode-powershell/package.json
Line 537 in 08f0bc5
But this does not work. With the full version number the Plugin falls back to PowerShell 5.1.x (Full Framework) .
But
"powershell.powerShellDefaultVersion": "PowerShell Core 6 (x64)"
is working fine.I don't know what the expected behavior is, so i didn't provide a PR for that now.
The text was updated successfully, but these errors were encountered: