Skip to content

Folding provider tests are failing in VSCode 1.25 #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glennsarti opened this issue Jul 9, 2018 · 2 comments · Fixed by #1416
Closed

Folding provider tests are failing in VSCode 1.25 #1413

glennsarti opened this issue Jul 9, 2018 · 2 comments · Fixed by #1416

Comments

@glennsarti
Copy link
Contributor

This is due to the vscode-textmate module going from v3 to v4 and adding breaking changes.
@glennsarti
Copy link
Contributor Author

e.g. https://ci.appveyor.com/project/PowerShell/vscode-powershell/build/1.7.0-insiders-654

@glennsarti
Copy link
Contributor Author

There is a WIP PR up at #1410

glennsarti pushed a commit to glennsarti/vscode-powershell that referenced this issue Jul 9, 2018
@rkeithhill @glennsarti
(PowerShellGH-1413) Update grammar parsing for vscode-textmate v4 module
fe2f631 
VS Code 1.25 has updated the imported vsode-textmate module from v3 to v4, which
introduced some breaking changes.  This commit updates the grammar loader;

* Uses a thenable grammar parser, as V4 of the module is all asynchronous
* Uses a simple method detection technique on the Registry object to determine
  if we're using v3 or v4+ of the textmate module, and then branch the code
  accordingly.

  Note that this functionality can only be tested manually due to how the
  vscode-textmate module is incorporated into VSCode and the test-suite.
glennsarti pushed a commit to glennsarti/vscode-powershell that referenced this issue Jul 9, 2018
@rkeithhill @glennsarti
(PowerShellGH-1413) Update grammar parsing for vscode-textmate v4 module
de00cf3 
VS Code 1.25 has updated the imported vsode-textmate module from v3 to v4, which
introduced some breaking changes.  This commit updates the grammar loader;

* Uses a thenable grammar parser, as V4 of the module is all asynchronous
* Uses a simple method detection technique on the Registry object to determine
  if we're using v3 or v4+ of the textmate module, and then branch the code
  accordingly.

  Note that this functionality can only be tested manually due to how the
  vscode-textmate module is incorporated into VSCode and the test-suite.
rkeithhill pushed a commit that referenced this issue Jul 10, 2018
@glennsarti @rkeithhill
(GH-1413) Update grammar parsing for vscode-textmate v4 module (#1414)
5a62292 
* (maint) Add a logging interface

Previously the logging object had no interface which made testing difficult.
This commit adds a new interface which new features can use, which makes mocking
the logging object possible.

* (GH-1413) Update grammar parsing for vscode-textmate v4 module

VS Code 1.25 has updated the imported vsode-textmate module from v3 to v4, which
introduced some breaking changes.  This commit updates the grammar loader;

* Uses a thenable grammar parser, as V4 of the module is all asynchronous
* Uses a simple method detection technique on the Registry object to determine
  if we're using v3 or v4+ of the textmate module, and then branch the code
  accordingly.

  Note that this functionality can only be tested manually due to how the
  vscode-textmate module is incorporated into VSCode and the test-suite.

* Update Folding.ts

Add newline between copyright header and body
glennsarti added a commit to glennsarti/vscode-powershell that referenced this issue Jul 10, 2018
@glennsarti
(PowerShellGH-1413) Resolve promise correctly in Folding feature
799dad7 
Previously in PR PowerShell#1414 the Folding provider was updated, however the promise
resolution was incorrect.  This caused the grammar load to never trigger the
Then command.  This commit instead uses the correct way to return the value
for the promise and, when then triggers the Then statement correctly.
@glennsarti glennsarti mentioned this issue Jul 10, 2018
Merged
3 tasks
rjmholt pushed a commit that referenced this issue Jul 10, 2018
@glennsarti @rjmholt
(GH-1413) Resolve promise correctly in Folding feature (#1416)
7a9df00 
Previously in PR #1414 the Folding provider was updated, however the promise
resolution was incorrect.  This caused the grammar load to never trigger the
Then command.  This commit instead uses the correct way to return the value
for the promise and, when then triggers the Then statement correctly.
rjmholt pushed a commit that referenced this issue Jul 11, 2018
@glennsarti
(GH-1413) Update grammar parsing for vscode-textmate v4 module (#1414)
2d36283 
* (maint) Add a logging interface

Previously the logging object had no interface which made testing difficult.
This commit adds a new interface which new features can use, which makes mocking
the logging object possible.

* (GH-1413) Update grammar parsing for vscode-textmate v4 module

VS Code 1.25 has updated the imported vsode-textmate module from v3 to v4, which
introduced some breaking changes.  This commit updates the grammar loader;

* Uses a thenable grammar parser, as V4 of the module is all asynchronous
* Uses a simple method detection technique on the Registry object to determine
  if we're using v3 or v4+ of the textmate module, and then branch the code
  accordingly.

  Note that this functionality can only be tested manually due to how the
  vscode-textmate module is incorporated into VSCode and the test-suite.

* Update Folding.ts

Add newline between copyright header and body
rjmholt pushed a commit that referenced this issue Jul 11, 2018
@glennsarti
(GH-1413) Resolve promise correctly in Folding feature (#1416)
17c27d3 
Previously in PR #1414 the Folding provider was updated, however the promise
resolution was incorrect.  This caused the grammar load to never trigger the
Then command.  This commit instead uses the correct way to return the value
for the promise and, when then triggers the Then statement correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-1413) Resolve promise correctly in Folding feature glennsarti/vscode-powershell
1 participant
@glennsarti