Skip to content

TSLint should enforce license headers #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glennsarti opened this issue Jun 30, 2018 · 0 comments · Fixed by #1396
Closed

TSLint should enforce license headers #1394

glennsarti opened this issue Jun 30, 2018 · 0 comments · Fixed by #1396

Comments

@glennsarti
Copy link
Contributor

I've contributed to a Java based GPL3 licensed product and it had a unit test to ensure that all files had the appropriate license header. Given the conversation in #1355 that all files (well TS at least) should have a standard license header it would make sense to add a TS Lint rule to enforce this.

Perhaps palantir/tslint#1441 gives guidance on how to enforce this rule.
@glennsarti glennsarti mentioned this issue Jun 30, 2018
Merged
18 tasks
rkeithhill added a commit that referenced this issue Jul 1, 2018
@rkeithhill
Add tslint rule file-header to enforce copyright in TS files
f3ab8f2 
I would like to add a "fix" string which this page says is supported:
https://palantir.github.io/tslint/rules/file-header/

But the comment style of the fix doesn't follow our style and is
apparently not configurable.
```
/*!
 * copyright line
 */
```
Fix #1394
@rkeithhill rkeithhill mentioned this issue Jul 1, 2018
Merged
3 tasks
TylerLeonhardt pushed a commit that referenced this issue Jul 2, 2018
@rkeithhill @TylerLeonhardt
Add tslint rule file-header to enforce copyright in TS files (#1396)
8d65def 
I would like to add a "fix" string which this page says is supported:
https://palantir.github.io/tslint/rules/file-header/

But the comment style of the fix doesn't follow our style and is
apparently not configurable.
```
/*!
 * copyright line
 */
```
Fix #1394
rjmholt pushed a commit that referenced this issue Jul 11, 2018
@rkeithhill
Add tslint rule file-header to enforce copyright in TS files (#1396)
cc14106 
I would like to add a "fix" string which this page says is supported:
https://palantir.github.io/tslint/rules/file-header/

But the comment style of the fix doesn't follow our style and is
apparently not configurable.
```
/*!
 * copyright line
 */
```
Fix #1394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tslint rule file-header to enforce copyright in TS files PowerShell/vscode-powershell
1 participant
@glennsarti