Skip to content

Function Snippet should not output in a C# way #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kilasuit opened this issue Jun 9, 2018 · 0 comments · Fixed by #1354
Closed

Function Snippet should not output in a C# way #1353

kilasuit opened this issue Jun 9, 2018 · 0 comments · Fixed by #1354

Comments

@kilasuit
Copy link
Contributor

kilasuit commented Jun 9, 2018 •
edited by TylerLeonhardt
Loading

System Details

image

Issue Description

Function snippet uses a more c# style over a more commonly standard PowerShell style for the non-advanced function definition. This leads to more reformatting if you need to update a simple function to an advanced function and therefore adds more unnecessary work in the longer term

image
@kilasuit kilasuit mentioned this issue Jun 9, 2018
Merged
3 tasks
rjmholt pushed a commit that referenced this issue Jun 12, 2018
@kilasuit @rjmholt
Edit snippet to fix issue #1353 (#1354)
9bf58a7 
Edit snippet to fix issue 1353

* Default "function" snippet now has param() block
* Old function snippet now available as "Function-Inline"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edited Snippet to fix issue #1353
1 participant
@kilasuit