Skip to content

Integrated Console doesn't start when missing powerShellExePath setting #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daviwil opened this issue Aug 24, 2017 · 1 comment
Closed
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Aug 24, 2017

The latest VS Code Insiders builds have caused a change in behavior which causes the PS Integrated Console to not launch when the "powershell.powerShellExePath setting isn't specified. There must have been an API change related to default setting values.

@daviwil daviwil modified the milestones: 1.5.0, 1.4.2 Aug 24, 2017
daviwil added a commit to daviwil/vscode-powershell that referenced this issue Sep 5, 2017
This change introduces a new module that contains all the logic for
determining the current OS platform, process architecture and OS
architecture for use in determining available Windows PowerShell EXE
paths.  This module helps resolve problems that were introduced by the
new 64-bit distribution of Visual Studio Code.

Fixes PowerShell#1008
Fixes PowerShell#1007
Fixes PowerShell#1006
Fixes PowerShell#993
@daviwil
Copy link
Contributor Author

daviwil commented Sep 5, 2017

Wasn't actually able to reproduce this issue when I tried it, but I made sure that the correct default value will get sent through no matter what.

daviwil added a commit that referenced this issue Sep 5, 2017
This change introduces a new module that contains all the logic for
determining the current OS platform, process architecture and OS
architecture for use in determining available Windows PowerShell EXE
paths.  This module helps resolve problems that were introduced by the
new 64-bit distribution of Visual Studio Code.

Fixes #1008
Fixes #1007
Fixes #1006
Fixes #993
@daviwil daviwil closed this as completed in f2aa2a2 Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

1 participant