WIP: Update template to use PSL 5.1.0 #66
Conversation
| "description": "PowerShell Standard 5.1" | ||
| }, | ||
| { | ||
| "choice": "3.0.0-preview-02", | ||
| "description": "PowerShell Standard 3.0" | ||
| } | ||
| ], | ||
| "replaces": "5.1.0-preview-06" | ||
| "replaces": "5.1.0" |
There was a problem hiding this comment.
I'm not sure what this does exactly but figured it had to be changed to remove the -preview-06 ref.
There was a problem hiding this comment.
this is the right call - basically, it will replace instances of what's in replaces with the choice based on what flags are used when dotnet new is called.
|
Also, the README.md refers to So if this PR were to go through using |
|
AFAIK, a 5.1.1 isn't happening any time soon so lets go with 5.1.0. Can you update the README to refer to 5.1.0? |
|
Sure, I'll do that tonight. |
| <file src="__INPATHROOT__\release\out\PowerShellStandard.Library.5.1.1.nupkg" signType="CP-401405" | ||
| dest="__OUTPATHROOT__\release\out\PowerShellStandard.Library.5.1.1.nupkg" /> | ||
| <file src="__INPATHROOT__\release\out\PowerShellStandard.Library.5.1.0.nupkg" signType="CP-401405" | ||
| dest="__OUTPATHROOT__\release\out\PowerShellStandard.Library.5.1.0.nupkg" /> |
There was a problem hiding this comment.
@JamesWTruher can you speak to this change? Why does the signing.xml have 5.1.1?
There was a problem hiding this comment.
@JamesWTruher @TylerLeonhardt Any chance of getting this PR moved through? It would be nice if the template folks installed with dotnet worked better. :-)
There was a problem hiding this comment.
yah - sorry, I thought I had pushed 5.1.1 months ago. I'll make this happen
|
The changes found in b69d5e6 added a net452 assembly, along with a number of other additions, but somehow was unreleased. I'll take this PR, but produce another PR to push the version everywhere to 5.1.1. I'm uncomfortable with doing another release without updating the release number |
|
Works for me. Thanks! |
There are a few things that need to be worked out here. There was a PR merged by @JamesWTruher back in March that updated parts of the template for use of
PSL 5.1.1. But I don't see a 5.1.1 version on nuget.org. The latest there is5.1.0.Also, I installed the template today and the project it scaffolded for me was still using
5.1.0-preview-06. So I think we need an update to move to5.1.0or perhaps5.1.1when it gets published to nuget.org.I updated the generated module manifest copyright to 2019 and added code-block language specifiers in the README.md file to eliminate the markdownlint warnings I was getting.