Skip to content

Add devcontainer support for building in container #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
#-------------------------------------------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
#-------------------------------------------------------------------------------------------------------------

FROM mcr.microsoft.com/dotnet/core/sdk:2.1.602
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you target the new .NET Core 3.0+ SDK container it contains PowerShell and you won't need to install it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree but before that the main build needs to move .net core 3 (I vaguely remember the build to not work with it, but maybe that was an issue with one of the previews)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood point. Looks like that is the case: #1095

Maybe we can try to get that figured out first before this goes in? My team put in work to get PowerShell inside the SDK container - I'd love to leverage that if possible as a form of dogfooding it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjmholt abandoned that PR so I'm ok with this going in as is. When we move to .NET SDK 3.0, we can revisit changing the container.


# Avoid warnings by switching to noninteractive
ENV DEBIAN_FRONTEND=noninteractive

# Configure apt and install packages
RUN apt-get update \
&& apt-get -y install --no-install-recommends apt-utils 2>&1 \
#
# Verify git, process tools, lsb-release (common in install instructions for CLIs) installed
&& apt-get -y install git procps lsb-release \
#
# Clean up
&& apt-get autoremove -y \
&& apt-get clean -y \
&& rm -rf /var/lib/apt/lists/*

# Install PowerShell
RUN apt-get update \
&& apt-get install curl gnupg apt-transport-https -y \
&& curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \
&& echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-debian-stretch-prod stretch main" > /etc/apt/sources.list.d/microsoft.list \
&& apt-get update \
&& apt-get install -y powershell

# Switch back to dialog for any ad-hoc use of apt-get
ENV DEBIAN_FRONTEND=dialog

SHELL ["/usr/bin/pwsh", "-Command"]

# Install PowerShell modules required for building and testing
RUN Install-Module InvokeBuild -Force; Install-Module Pester -Force
RUN Install-Module platyPS -Force; Install-Module Pester -Force
RUN Install-Module Pester -Force; Install-Module Pester -Force
14 changes: 14 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// See https://aka.ms/vscode-remote/devcontainer.json for format details.
{
"name": "C# (.NET Core 2.1) and PowerShell on Debian 9",
"dockerFile": "Dockerfile",

"postCreateCommand": "dotnet restore",

"extensions": [
"ms-vscode.csharp",
"ms-vscode.powershell",
"davidanson.vscode-markdownlint",
"editorconfig.editorconfig"
]
}