-
Notifications
You must be signed in to change notification settings - Fork 234
Add devcontainer support for building in container #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
faf9215
Add devcontainer support for building in container
bergmeister 7f7d83c
Inline apt-get statements and remove redundant Pester installs
bergmeister d3398f6
fix syntax
bergmeister d562917
final cleanup
bergmeister a6ad5de
Update .devcontainer/devcontainer.json
bergmeister 3745ae7
Update .devcontainer/Dockerfile
bergmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#------------------------------------------------------------------------------------------------------------- | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information. | ||
#------------------------------------------------------------------------------------------------------------- | ||
|
||
FROM mcr.microsoft.com/dotnet/core/sdk:2.1.602 | ||
bergmeister marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Avoid warnings by switching to noninteractive | ||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
# Configure apt and install packages | ||
RUN apt-get update \ | ||
&& apt-get -y install --no-install-recommends apt-utils 2>&1 \ | ||
# | ||
# Verify git, process tools, lsb-release (common in install instructions for CLIs) installed | ||
&& apt-get -y install git procps lsb-release \ | ||
# | ||
# Clean up | ||
&& apt-get autoremove -y \ | ||
&& apt-get clean -y \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
# Install PowerShell | ||
RUN apt-get update \ | ||
bergmeister marked this conversation as resolved.
Show resolved
Hide resolved
|
||
&& apt-get install curl gnupg apt-transport-https -y \ | ||
&& curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - \ | ||
&& echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-debian-stretch-prod stretch main" > /etc/apt/sources.list.d/microsoft.list \ | ||
&& apt-get update \ | ||
&& apt-get install -y powershell | ||
|
||
# Switch back to dialog for any ad-hoc use of apt-get | ||
ENV DEBIAN_FRONTEND=dialog | ||
|
||
SHELL ["/usr/bin/pwsh", "-Command"] | ||
|
||
# Install PowerShell modules required for building and testing | ||
RUN Install-Module InvokeBuild -Force; Install-Module Pester -Force | ||
RUN Install-Module platyPS -Force; Install-Module Pester -Force | ||
RUN Install-Module Pester -Force; Install-Module Pester -Force | ||
bergmeister marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// See https://aka.ms/vscode-remote/devcontainer.json for format details. | ||
{ | ||
"name": "C# (.NET Core 2.1) and PowerShell on Debian 9", | ||
"dockerFile": "Dockerfile", | ||
|
||
"postCreateCommand": "dotnet restore", | ||
|
||
"extensions": [ | ||
"ms-vscode.csharp", | ||
"ms-vscode.powershell", | ||
bergmeister marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"davidanson.vscode-markdownlint", | ||
"editorconfig.editorconfig" | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you target the new .NET Core 3.0+ SDK container it contains PowerShell and you won't need to install it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree but before that the main build needs to move .net core 3 (I vaguely remember the build to not work with it, but maybe that was an issue with one of the previews)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gooood point. Looks like that is the case: #1095
Maybe we can try to get that figured out first before this goes in? My team put in work to get PowerShell inside the SDK container - I'd love to leverage that if possible as a form of dogfooding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjmholt abandoned that PR so I'm ok with this going in as is. When we move to .NET SDK 3.0, we can revisit changing the container.