WIP Cherry pick for legacy #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owerShell#866) The 7 exceptions that are caught now are doc'd in: https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.-ctor?view=netframework-4.7.2#System_IO_FileStream__ctor_System_String_System_IO_FileMode_System_IO_FileAccess_
* Added `AsNewFile` switch, plus, if a file is not open, it creates a new one * Update module/PowerShellEditorServices/Commands/Public/Out-CurrentFile.ps1 Co-Authored-By: dfinke <[email protected]>
* Return the start line number for Describe block Supports PR 1776 in vscode-powershell * Null check pesterSymbol.ScriptRegion * Update comment to cause new build to kick off * Whitespace change to kick off a new build
* Add attach to local runspace. * Remove comment. * Use single runspaceId property. * Remove unnecessary processId check. * Factored if. * Update src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs It's neat that we can just commit a suggestion. Co-Authored-By: adamdriscoll <[email protected]> * Use runspace rather than dynamic. * Accept process ID for GetRunspaceRequest. * Clean up.
TylerLeonhardt
requested review from
rjmholt,
rkeithhill and
SeeminglyScience
as code owners
rkeithhill
reviewed
Mar 19, 2019
|
|
||
| psCommand.AddCommand("Get-Runspace"); | ||
|
|
||
| StringBuilder sb = new StringBuilder(); |
There was a problem hiding this comment.
What happened to the var here?
rkeithhill
reviewed
Mar 19, 2019
| processId = "current"; | ||
| } | ||
|
|
||
| var isNotCurrentProcess = processId != null && processId != "current"; |
There was a problem hiding this comment.
A few parens here would make this a bit easier to visually parse.
There was a problem hiding this comment.
Also fixed in #881
rkeithhill
approved these changes
Mar 19, 2019
|
not sure why appveyor isn't triggering a build... |
|
since the implementation of #881 would need to be different for legacy, I'm going to merge this in and then send a PR to legacy with that implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH
Waiting on #881