Skip to content

Temporarily disable deemphasized stack frames to fix VSCode-powershell issue 1750 #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Temporarily disable deemphasized stack frames to fix VSCode-powershell issue 1750 #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/PowerShellEditorServices/Debugging/StackFrameDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,14 @@ static internal StackFrameDetails Create(
string scriptPath = (callStackFrameObject.Properties["ScriptName"].Value as string) ?? NoFileScriptPath;
int startLineNumber = (int)(callStackFrameObject.Properties["ScriptLineNumber"].Value ?? 0);

if (workspaceRootPath != null &&
invocationInfo != null &&
!scriptPath.StartsWith(workspaceRootPath, StringComparison.OrdinalIgnoreCase))
{
isExternal = true;
}
// TODO: RKH 2019-03-07 Temporarily disable "external" code until I have a chance to add
// settings to control this feature.
//if (workspaceRootPath != null &&
// invocationInfo != null &&
// !scriptPath.StartsWith(workspaceRootPath, StringComparison.OrdinalIgnoreCase))
//{
// isExternal = true;
//}

return new StackFrameDetails
{
Expand Down