Fix #827 Pester TestName w/expandable str returns nothing #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update will return null to indicate that the TestName arg was present but not something we could evaluate. The extension will see the null value and pop a dialog box.
rjmholt
reviewed
Jan 17, 2019
| testName = testNameStrAst.Value; | ||
| return true; | ||
| } | ||
| else if (commandElementAst is ExpandableStringExpressionAst) |
There was a problem hiding this comment.
No need for the else here -- above clause always returns
There was a problem hiding this comment.
This could be a pattern match too since it just tests type overloads. But I'm easy either way :)
rjmholt
approved these changes
Jan 17, 2019
TylerLeonhardt
approved these changes
Jan 17, 2019
|
Hmm, I think the Codacy error is whacked. There are curly braces on the |
|
Yeah that's weird... ignore it. This looks great! |
|
Thanks. I'll merge this once the corresponding vscode-powerhell PR has been approved/merged. |
TylerLeonhardt
deleted the
rkeithhill/fix-827-pester-expandable-test-name-string
branch
bergmeister
added a commit
to bergmeister/PowerShellEditorServices
that referenced
this pull request
Jan 22, 2019
…othing (PowerShell#851)" This reverts commit 161a3ed.
bergmeister
added a commit
to bergmeister/PowerShellEditorServices
that referenced
this pull request
Jan 22, 2019
…eturns nothing (PowerShell#851)"" This reverts commit f26755f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update will return null to indicate that the TestName arg was
present but not something we could evaluate. The extension will see the
null value and pop a dialog box.