Skip to content

Fix VSCODE 1683 - HelpCommentReqHdlr crash on GetFile #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix VSCODE 1683 - HelpCommentReqHdlr crash on GetFile #850

merged 1 commit into from
Jan 17, 2019

Conversation

rkeithhill
Copy link
Contributor

@rkeithhill rkeithhill commented Jan 16, 2019 •
edited
Loading

Fix for one of the issues documented in PowerShell/vscode-powershell#1683

This is a quick fix, still need to make a pass through and look at all uses of GetFile().

TylerLeonhardt
TylerLeonhardt approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @rkeithhill 😊

@TylerLeonhardt TylerLeonhardt merged commit da3d920 into master Jan 17, 2019
@TylerLeonhardt TylerLeonhardt deleted the rkeithhill/fix-help-comment-crash-get-file branch January 17, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@rjmholt rjmholt rjmholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkeithhill @TylerLeonhardt @rjmholt