switch an instance of GetFile to TryGetFile #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
approved these changes
Jan 11, 2019
|
Yep I totally agree. I imagine there are more than 1 instances of this... I really need to audit the code on how many times we're not honoring case-sensitive file systems. |
SeeminglyScience
approved these changes
Jan 11, 2019
There was a problem hiding this comment.
LGTM
Yep I totally agree. I imagine there are more than 1 instances of this... I really need to audit the code on how many times we're not honoring case-sensitive file systems.
Yeah I know for sure it's come up in review at least once or twice before. A sweep for other instances sounds like a great idea.
rjmholt
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PowerShell/vscode-powershell#1689
to make sure we don't hit a NRE here.
The
ToLoweris suspicious a few lines down... might have to revisit that...