Workaround "attach to process" hang #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Jan 10, 2019
rkeithhill
approved these changes
Jan 10, 2019
SeeminglyScience
approved these changes
Jan 10, 2019
| // Attaching to process currently needs to be marked as a local session | ||
| // so we skip this if block if the runspace is from Enter-PSHostProcess | ||
| if (hostName.Equals("ServerRemoteHost", StringComparison.Ordinal) | ||
| && runspace.OriginalConnectionInfo.GetType().ToString() != "System.Management.Automation.Runspaces.NamedPipeConnectionInfo") |
There was a problem hiding this comment.
May be a good idea to do a null check here. I think there are a couple ConnectionInfo's that do not get written here but are still ServerRemoteHost
Suggested change
| && runspace.OriginalConnectionInfo.GetType().ToString() != "System.Management.Automation.Runspaces.NamedPipeConnectionInfo") | |
| && runspace.OriginalConnectionInfo != null | |
| && runspace.OriginalConnectionInfo.GetType().ToString() != "System.Management.Automation.Runspaces.NamedPipeConnectionInfo") |
There was a problem hiding this comment.
better yet:
runspace.OriginalConnectionInfo?.GetType().ToString() != "System.Management.Automation.Runspaces.NamedPipeConnectionInfo"There was a problem hiding this comment.
Whoops! Got stuck in bool mode and had it in my head you'd have to do ?? false. Nice catch :)
rjmholt
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Attach to process" debug config. Originally broken in #801.
Unfortunately, I'm not 100% sure why the Enter-PSHostProcess session being treated as a Remote session causes issues but this code was majorly refactored in 2.0.0 branch so I'm just going to make this small change for now.
fixes PowerShell/vscode-powershell#1684