Update version for preview builds #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Dec 19, 2018
| @@ -1,4 +1,4 @@ | |||
| version: '1.10.2{build}' | |||
| version: '1.10.3{build}' | |||
There was a problem hiding this comment.
Seems like we should just have to set this version once - here - and then use a small PS script (or inline commands) to modify the PowerShellEditorServices.Common.props and module/PowerShellEditorServices/PowerShellEditorServices.psd1 files before starting the build.
There was a problem hiding this comment.
Given that in time we'll move to Azure DevOps, we should probably use the module version as the canonical one.
But that complicates life since this yaml file needs to be checked in with the version number.
rkeithhill
approved these changes
Dec 19, 2018
TylerLeonhardt
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.