Compile against net452 because net451 is not supported any more #828
Conversation
bergmeister
requested review from
rjmholt and
SeeminglyScience
as code owners
There was a problem hiding this comment.
LGTM! I've actually been wanting to do this, but hadn't had time to do the due diligence on supported upgrades yet. Thanks @bergmeister.
| @@ -3,7 +3,7 @@ | |||
| <PropertyGroup> | |||
| <AssemblyTitle>PowerShell Editor Services</AssemblyTitle> | |||
| <Description>Provides common PowerShell editor capabilities as a .NET library.</Description> | |||
| <TargetFrameworks>netstandard1.6;net451</TargetFrameworks> | |||
| <TargetFrameworks>netstandard1.6;net452</TargetFrameworks> | |||
There was a problem hiding this comment.
I wonder if it would be worth it to move to netstandard2.0 for .NET Core builds?
There was a problem hiding this comment.
I have been wondering the same. Would there be any reason not to?
There was a problem hiding this comment.
What version of .NET Core did 6.0 & 6.1 ship with? Seems like at least 6.0 was 1.x so maybe we're stuck with 1.6 until we're willing to drop support for 6.0 (and maybe 6.1). Doh!
There was a problem hiding this comment.
PSCore 6.0 and 6.1 both run on .Net Core 2.1 and implement netstandard2.0. The only hypothetical reason not to would be a reduced set of runtimes but this would only apply in restricted scenarios like e.g. mobile phone apps using Xamarin.
But I have been told not to submit a PR for such changes because the 2.0.0 branch upgrades it to .netstandard2.0 and PSStandard already. PR #830 got closed for that reason for example.
There was a problem hiding this comment.
They're both compatible I'm pretty sure. The real work in the upgrade was eliminating net45 stuff and things PSStandard didn't like. In which case I think we may as well upgrade to netstandard2.0. But @TylerLeonhardt may have good reasons not to
There was a problem hiding this comment.
6.0 ships with .NET Core 2.0
There was a problem hiding this comment.
Unless something changed in the last patch version
|
Ok, given that net451 is EOL, I think we want the net452 upgrade. |
|
Will wait for other approvals |
Technically,
net452is an in-place upgrade anyway that does not need recompilation but for best practices, PSES should compile against the lowest support .Net Framework so that it works on each Windows machine (as long as they are sufficiently patched), more details are here: https://support.microsoft.com/en-us/help/17455/lifecycle-faq-net-frameworkSimilarly, after that we should move away from
netcoreapp2.0, which is also not supported any more