Skip to content

Fix crash when untitled files are opened as PowerShell #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Fix crash when untitled files are opened as PowerShell #815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
550d0e3
Fix crash when untitled files are opened as PowerShell
rjmholt Dec 12, 2018
72eed8d
Change TODO to discussion note
rjmholt Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/PowerShellEditorServices/Workspace/ScriptFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,16 @@ private void ParseFileContents()
.Select(ScriptFileMarker.FromParseError)
.ToArray();

//Get all dot sourced referenced files and store them
// Untitled files have no directory
// Discussed in https://github.com/PowerShell/PowerShellEditorServices/pull/815.
// Rather than working hard to enable things for untitled files like a phantom directory,
// users should save the file.
if (IsUntitledPath(this.FilePath))
{
return;
}

// Get all dot sourced referenced files and store them
this.ReferencedFiles = AstOperations.FindDotSourcedIncludes(this.ScriptAst, Path.GetDirectoryName(this.FilePath));
}

Expand Down