-
Notifications
You must be signed in to change notification settings - Fork 234
Add managed thread id to log output to add debugging threading issues #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also update format to display method before filename, makes it easy to visually scan the log to see what is going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Thanks @rkeithhill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This will be very handy
@rkeithhill can you double check that vscode still gives you syntax highlighting like it does today? pretty sure it's just looking for dates and numbers but I just want to double check 😄 |
How about I simplify/lessen the output a bit more. I don't think the For 2.0.0, if Serilog supported
to
I'd compute the slice offset once and stash it in a static variable. But alas, Serilog doesn't appear to support If folks agree with these changes, I'll push my commit with them and then I'd like to merge this. |
OK, going for the presumptive close on the previous post. :-) If folks object, I'll rollback that last commit. |
Also update format to display method before filename, makes it easy to
visually scan the log to see what is going on.
Here is log output before this change:
And after: