For for issue #75, variables display isn't displaying anything for ge… #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for generic dictionaries like PSBoundParametersDictionary. Also enhanced the determination of what is expandable. We were not allowing structs like DateTime, TimeSpan and DictionaryEntry to expand. Changed test from !IsValueType to !IsPrimitive. Also enhanced the display of property values where we encounter an exception when trying to retrieve the property. Following VS debugger's lead on this on. You can see the display by looking at $Host.Runspace. And we also weren't displaying .NET properties for colletions and dictionaries. We now do that - in addition to the elements in the collection or dictionary. Also, don't try to add properties that are indexers.
| // We're in the realm of regular, unwrapped .NET objects | ||
| if (dictionary != null) | ||
| { | ||
| // Buckle up kids, this is a bit weird. We could not use the LINQ |
There was a problem hiding this comment.
Great comment! Thanks for adding that
|
Excellent work yet again, thank you for carrying us through the Hack Week :) |
daviwil
added a commit
that referenced
this pull request
Dec 14, 2015
…-bug For for issue #75, variables display isn't displaying anything for ge…
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
…h-filevar-fix Fix for PowerShell#76 - launch.json now uses as default launch path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…neric dictionaries like PSBoundParametersDictionary. Also enhanced the determination of what is expandable. We were not allowing structs like DateTime, TimeSpan and DictionaryEntry to expand. Changed test from !IsValueType to !IsPrimitive. Also enhanced the display of property values where we encounter an exception when trying to retrieve the property. Following VS debugger's lead on this on. You can see the display by looking at $Host.Runspace. And we also weren't displaying .NET properties for colletions and dictionaries. We now do that - in addition to the elements in the collection or dictionary. Also, don't try to add properties that are indexers.
@daviwil - this one is a bit more change in VariablesDetails.cs than I was anticipating. Please give it a good look over.