Fix signature handler regression #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
TylerLeonhardt,
rkeithhill and
SeeminglyScience
| foreach (ParameterInfo paramInfo in sig.Parameters) | ||
| var parameters = new ParameterInformation[parameterSets.Signatures[i].Parameters.Count()]; | ||
| int j = 0; | ||
| foreach (ParameterInfo param in parameterSets.Signatures[i].Parameters) |
There was a problem hiding this comment.
Can you use another for loop here instead of foreach since you need the index j anyway?
There was a problem hiding this comment.
I had that first, but changed it back because the Parameters property is an IEnumerable - so it can't be indexed.
The foreach means we can iterate over it without extra effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression where we don't accumulate signatures we discover.
I've now read through both the LINQ PRs I merged looking for this problem and this is the only other instance I found.