Skip to content

[Ignore] Prepare 1.9.0 release #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2018
Merged

[Ignore] Prepare 1.9.0 release #753

merged 1 commit into from
Sep 28, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Sep 28, 2018

😃

rkeithhill
rkeithhill approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkeithhill
Copy link
Contributor

Not a biggie but what prompted the bump to 1.9.0?

@rjmholt
Copy link
Contributor Author

rjmholt commented Sep 28, 2018

The help feature and the API deprecation in it. But we could do 1.8.5 instead, I don't mind either. Ideally we could merge my other change in first (which shouldn't be in the changelog -- it's @corbob's feature).

@rkeithhill
Copy link
Contributor

Since the extension isn't really a re-usable "library" I don't feel that strongly about semver rules. And it sounds like the help change could be viewed as a new feature anyway. So all good.

@rjmholt rjmholt merged commit fa6a969 into PowerShell:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeithhill rkeithhill rkeithhill approved these changes

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmholt @rkeithhill