Change Get-Help behavior to return local help when no online help available

src/PowerShellEditorServices.Protocol/LanguageServer/ShowOnlineHelpRequest.cs

@@ -7,10 +7,18 @@
 
 namespace Microsoft.PowerShell.EditorServices.Protocol.LanguageServer
 {
+    // We don't expect ShowOnlineHelpRequest to come from vscode anymore, but it could come from another editor.
+    // TODO: Note that it's deprecated if it's called???
     public class ShowOnlineHelpRequest
     {
         public static readonly
             RequestType<string, object, object, object> Type =
             RequestType<string, object, object, object>.Create("powerShell/showOnlineHelp");
     }
+        public class ShowHelpRequest
+    {
+        public static readonly
+            RequestType<string, object, object, object> Type =
+            RequestType<string, object, object, object>.Create("powerShell/showHelp");
+    }
 }

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -122,6 +122,7 @@ public void Start()
                 this.HandleDocumentRangeFormattingRequest);
 
             this.messageHandlers.SetRequestHandler(ShowOnlineHelpRequest.Type, this.HandleShowOnlineHelpRequest);
+            this.messageHandlers.SetRequestHandler(ShowHelpRequest.Type, this.HandleShowHelpRequest);
             this.messageHandlers.SetRequestHandler(ExpandAliasRequest.Type, this.HandleExpandAliasRequest);
 
             this.messageHandlers.SetRequestHandler(FindModuleRequest.Type, this.HandleFindModuleRequest);
@@ -230,22 +231,45 @@ await requestContext.SendResult(
                     }
                 });
         }
-
-        protected async Task HandleShowOnlineHelpRequest(
+        protected async Task HandleShowHelpRequest(
             string helpParams,
             RequestContext<object> requestContext)
         {
-            if (helpParams == null) { helpParams = "get-help"; }
-
-            var psCommand = new PSCommand();
-            psCommand.AddCommand("Get-Help");
-            psCommand.AddArgument(helpParams);
-            psCommand.AddParameter("Online");
-
-            await editorSession.PowerShellContext.ExecuteCommand<object>(psCommand);
-
+            const string CheckHelpScript = @"
+                [CmdletBinding()]
+                param (
+                    [String]$CommandName
+                )
+                Try {
+                    $null = Microsoft.PowerShell.Core\Get-Command $CommandName -ErrorAction Stop
+                } catch [System.Management.Automation.CommandNotFoundException] {
+                    $PSCmdlet.ThrowTerminatingError($PSItem)
+                }
+                try {
+                    $null = Microsoft.PowerShell.Core\Get-Help $CommandName -Online
+                } catch [System.Management.Automation.PSInvalidOperationException] {
+                    Microsoft.PowerShell.Core\Get-Help $CommandName -Full
+                }";
+            if (string.IsNullOrEmpty(helpParams)) { helpParams = "Get-Help"; }
+
+            PSCommand checkHelpPSCommand = new PSCommand()
+                .AddScript(CheckHelpScript, useLocalScope: true)
+                .AddArgument(helpParams);
+            await editorSession.PowerShellContext.ExecuteCommand<PSObject>(checkHelpPSCommand, sendOutputToHost: true);
             await requestContext.SendResult(null);
         }
+        protected async Task HandleShowOnlineHelpRequest(
+            string helpParams,
+            RequestContext<object> requestContext
+        )
+        {
+            const string deprecatedWarning = @"
+            Write-Warning ""'powerShell/showOnlineHelp' has been deprecated. Use 'powerShell/showHelp' instead.""";
+            PSCommand commandDeprecated = new PSCommand()
+                .AddScript(deprecatedWarning);
+            await editorSession.PowerShellContext.ExecuteCommand<PSObject>(commandDeprecated, sendOutputToHost: true);
+            await this.HandleShowHelpRequest(helpParams, requestContext);
+        }
 
         private async Task HandleSetPSSARulesRequest(
             object param,