Skip to content

Reduce allocations in the CodeLens providers #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 24, 2018
Merged

Reduce allocations in the CodeLens providers #719

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dccea93
Stop creating new JsonSerializers
Aug 8, 2018
d9d1d35
Reduce allocating operations in CodeLens providers
rjmholt Aug 8, 2018
4d200bd
Fix style mistake
rjmholt Aug 8, 2018
dc09c18
Fix style mistake
rjmholt Aug 8, 2018
76d7aad
Remove unused class
rjmholt Aug 8, 2018
4136b56
Use types instead of var
rjmholt Aug 8, 2018
4f7230f
Use SelectMany in simple non-linq case
rjmholt Aug 10, 2018
66d976c
Fix empty array handling
Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/PowerShellEditorServices.Host/CodeLens/CodeLensFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,8 @@ private async Task HandleCodeLensRequest(
CodeLensRequest codeLensParams,
RequestContext<LanguageServer.CodeLens[]> requestContext)
{
var scriptFile =
_editorSession.Workspace.GetFile(
codeLensParams.TextDocument.Uri);
ScriptFile scriptFile = _editorSession.Workspace.GetFile(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like. The rule for using var on my team is this - use var when the type of the RHS is obvious i.e. it's a literal, a new statement or type-cast. And also when required - anonymous types. Do not use var when the type is not obvious, which it usually isn't when invoking a method (or reading a property).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% agreed on that rule!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also 100% agree!

codeLensParams.TextDocument.Uri);

CodeLens[] codeLensResults = ProvideCodeLenses(scriptFile);

Expand Down
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices.Host/CodeLens/PesterCodeLensProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ private CodeLens[] GetPesterLens(
public CodeLens[] ProvideCodeLenses(ScriptFile scriptFile)
{
var lenses = new List<CodeLens>();
foreach (var symbol in _symbolProvider.ProvideDocumentSymbols(scriptFile))
foreach (SymbolReference symbol in _symbolProvider.ProvideDocumentSymbols(scriptFile))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only calls ProvideDocumentSymbols once and iterates through the result, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes. Why do you ask?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spoke to @SeeminglyScience about this. We're good

{
if (symbol is PesterSymbolReference pesterSymbol)
{
Expand Down
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices.Host/CodeLens/ReferencesCodeLensProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public async Task<CodeLens> ResolveCodeLensAsync(
ScriptFile[] references = _editorSession.Workspace.ExpandScriptReferences(
codeLens.File);

var foundSymbol = _editorSession.LanguageService.FindFunctionDefinitionAtLocation(
SymbolReference foundSymbol = _editorSession.LanguageService.FindFunctionDefinitionAtLocation(
codeLens.File,
codeLens.ScriptExtent.StartLineNumber,
codeLens.ScriptExtent.StartColumnNumber);
Expand Down