Skip to content

Prep for 1.8.2 release #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2018
Merged

Prep for 1.8.2 release #713

merged 3 commits into from
Jul 26, 2018

Conversation

TylerLeonhardt
Copy link
Member

🎉

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt as a code owner July 26, 2018 20:33
rkeithhill
rkeithhill reviewed Jul 26, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update:
PowerShellEditorServices.Common.props
module/PowerShellEditorServices/PowerShellEditorServices.psd1
AppVeyor.yml

@TylerLeonhardt
Copy link
Member Author

@rkeithhill yeah those are updated already - maybe you drilled into a particular commit diff?

@rkeithhill
Copy link
Contributor

rkeithhill commented Jul 26, 2018 •
edited
Loading

Yup, the previous release - https://github.com/PowerShell/PowerShellEditorServices/pull/702/files Oh, wait a tic, I see what you're saying and yes, I must have clicked on a particular commit in one of the email messages I got.

@TylerLeonhardt
Copy link
Member Author

Yeah those are all updated in this PR already :)

rkeithhill
rkeithhill approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rjmholt
rjmholt approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt TylerLeonhardt merged commit bd400a8 into PowerShell:master Jul 26, 2018
@TylerLeonhardt TylerLeonhardt deleted the prep-for-1.8.2 branch July 26, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeithhill rkeithhill rkeithhill approved these changes

@rjmholt rjmholt rjmholt approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TylerLeonhardt @rkeithhill @rjmholt