Skip to content

Change logging to use Serilog #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
May 25, 2018
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6f64497
Introduce serilog as logger backend
May 18, 2018
3781012
Put netstandard first in csproj files
rjmholt May 18, 2018
535d6c1
Add serilog logic, begin internal builder for logger
rjmholt May 18, 2018
4f35fef
Add log builder, switch log use, add comments
rjmholt May 19, 2018
9c6dc76
Add Serilog DLL to module output
rjmholt May 19, 2018
cf5086d
Add .NET Framework Serilog references
rjmholt May 19, 2018
ab9f87f
Add required XML comments
rjmholt May 19, 2018
79d7c6b
Partial revert line endings change
rjmholt May 20, 2018
c0214df
Revert line ending changes
rjmholt May 20, 2018
40c183c
Revert line ending changes
rjmholt May 20, 2018
be2f224
Revert line ending changes
rjmholt May 20, 2018
2f3b057
Revert line ending changes
rjmholt May 20, 2018
c73fd2b
Update comments to remove ILogger references
rjmholt May 20, 2018
a1e830d
Update Third Party Notices
rjmholt May 20, 2018
164b4d3
Make log files readable by other processes
rjmholt May 20, 2018
54f169d
Add XML comment for multiprocess option
rjmholt May 20, 2018
1997fba
Make file logging asynchronous
rjmholt May 20, 2018
6dd1c37
Make logger disposable for testing
rjmholt May 20, 2018
acd74f3
Add XML comment for dispose pattern
rjmholt May 20, 2018
3c1c51a
Fix csproj
rjmholt May 20, 2018
3f316ca
Make log level in messages uppercase
rjmholt May 20, 2018
a83e31c
Fix log output template
rjmholt May 20, 2018
d7bacd9
Make log levels log properly
rjmholt May 20, 2018
d8e03c4
Destructure log level enums
rjmholt May 20, 2018
bd6cc79
Use uppercase template modifier
rjmholt May 20, 2018
ec3d2a9
Try uppercase without destructuring
rjmholt May 20, 2018
fda57ef
Remove overengineered stuff, use unquoted strings in messages
rjmholt May 20, 2018
46fd4e6
Use pre-stringified log level
rjmholt May 20, 2018
2ce6b9c
Make exception logging work
rjmholt May 20, 2018
e27caff
Remove logger interface, remove log file sharing
rjmholt May 21, 2018
23cd8ec
Add static null logger
rjmholt May 21, 2018
d03ee64
Revert to ILogger usage
rjmholt May 21, 2018
9dcaef4
Revert logger comments
rjmholt May 21, 2018
64dd41d
Revert remaining comment changes
rjmholt May 21, 2018
9ecf846
Add newlines to log lines
rjmholt May 21, 2018
fb7fc0f
Remove extraneous multiprocess option, improve comments
May 21, 2018
54a53bb
Merge branch 'master' of https://github.com/rjmholt/PowerShellEditorS…
May 23, 2018
e9becd1
Address @SeeminglyScience feedback, correct log strings and templates…
May 23, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions PowerShellEditorServices.build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,13 @@ task TestServer -If { !$script:IsUnix } {
exec { & $script:dotnetExe xunit -configuration $Configuration -framework net452 -verbose -nobuild }
}

task TestProtocol -If { !$script:IsUnix} {
task TestProtocol -If { !$script:IsUnix } {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the config line to trim trailing whitespace if/when we add a .editorconfig file. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! I think the .editorconfig is a good idea.

Do you mean here I should remove the space I added before the brace?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, bad example. There were some trailing spaces after a chained exception filter that got removed. That's where the editorconfig file would have helped me where I use VS and it doesn't normally trim trailing whitespace.

Set-Location .\test\PowerShellEditorServices.Test.Protocol\
exec { & $script:dotnetExe build -c $Configuration -f net452 }
exec { & $script:dotnetExe xunit -configuration $Configuration -framework net452 -verbose -nobuild }
}

task TestHost -If { !$script:IsUnix} {
task TestHost -If { !$script:IsUnix } {
Set-Location .\test\PowerShellEditorServices.Test.Host\
exec { & $script:dotnetExe build -c $Configuration -f net452 }
exec { & $script:dotnetExe xunit -configuration $Configuration -framework net452 -verbose -nobuild }
Expand All @@ -204,10 +204,14 @@ task LayoutModule -After Build {
New-Item -Force $PSScriptRoot\module\PowerShellEditorServices\bin\Desktop -Type Directory | Out-Null
New-Item -Force $PSScriptRoot\module\PowerShellEditorServices\bin\Core -Type Directory | Out-Null

Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices\bin\$Configuration\netstandard1.6\publish\Serilog*.dll -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Core\

Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices.Host\bin\$Configuration\netstandard1.6\* -Filter Microsoft.PowerShell.EditorServices*.dll -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Core\
Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices.Host\bin\$Configuration\netstandard1.6\UnixConsoleEcho.dll -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Core\
Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices.Host\bin\$Configuration\netstandard1.6\libdisablekeyecho.* -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Core\
if (!$script:IsUnix) {
Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices\bin\$Configuration\net451\Serilog*.dll -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Desktop

Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices.Host\bin\$Configuration\net451\* -Filter Microsoft.PowerShell.EditorServices*.dll -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Desktop\
Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices.Host\bin\$Configuration\net451\Newtonsoft.Json.dll -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Desktop\
Copy-Item -Force -Path $PSScriptRoot\src\PowerShellEditorServices.Host\bin\$Configuration\net451\UnixConsoleEcho.dll -Destination $PSScriptRoot\module\PowerShellEditorServices\bin\Desktop\
Expand Down
74 changes: 73 additions & 1 deletion Third Party Notices.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This file is based on or incorporates material from the projects listed below (T
UnixConsoleEcho

Copyright (c) 2017 Patrick Meinecke
Provided for Informational Purposes Only
Provided for Informational Purposes Only

MIT License

Expand All @@ -14,3 +14,75 @@ Permission is hereby granted, free of charge, to any person obtaining a copy of
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

---

Serilog

Copyright 2013-2015 Serilog Contributors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

---

Serilog.Sinks.Async

Copyright 2013-2015 Serilog Contributors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

---

Serilog.Sinks.File

Copyright 2013-2015 Serilog Contributors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

---

Serilog.Sinks.Console

Copyright 2013-2015 Serilog Contributors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,4 @@ private class CodeLensData
public string ProviderId {get; set; }
}
}
}
}
5 changes: 4 additions & 1 deletion src/PowerShellEditorServices.Host/EditorServicesHost.cs
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ public EditorServicesHost(
/// <param name="logLevel">The minimum level of log messages to be written.</param>
public void StartLogging(string logFilePath, LogLevel logLevel)
{
this.logger = new FileLogger(logFilePath, logLevel);
this.logger = Logging.CreateLogger()
.LogLevel(logLevel)
.AddLogFile(logFilePath)
.Build();

#if CoreCLR
FileVersionInfo fileVersionInfo =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<PropertyGroup>
<AssemblyTitle>PowerShell Editor Services Host Process</AssemblyTitle>
<Description>Provides a process for hosting the PowerShell Editor Services library exposed by a JSON message protocol.</Description>
<TargetFrameworks>net451;netstandard1.6</TargetFrameworks>
<TargetFrameworks>netstandard1.6;net451</TargetFrameworks>
<AssemblyName>Microsoft.PowerShell.EditorServices.Host</AssemblyName>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ public static async Task<TcpSocketClientChannel> Connect(
return clientChannel;
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ protected override void Shutdown()
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<PropertyGroup>
<AssemblyTitle>PowerShell Editor Services Host Protocol Library</AssemblyTitle>
<Description>Provides message types and client/server APIs for the PowerShell Editor Services JSON protocol.</Description>
<TargetFrameworks>net451;netstandard1.6</TargetFrameworks>
<TargetFrameworks>netstandard1.6;net451;</TargetFrameworks>
<AssemblyName>Microsoft.PowerShell.EditorServices.Protocol</AssemblyName>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public DebugAdapter(
}

/// <summary>
/// Gets a boolean that indicates whether the current debug adapter is
/// Gets a boolean that indicates whether the current debug adapter is
/// using a temporary integrated console.
/// </summary>
public bool IsUsingTempIntegratedConsole { get; private set; }
Expand Down Expand Up @@ -506,7 +506,7 @@ protected async Task HandleSetBreakpointsRequest(
}
}
catch (Exception e) when (
e is FileNotFoundException ||
e is FileNotFoundException ||
e is DirectoryNotFoundException ||
e is IOException ||
e is NotSupportedException ||
Expand Down Expand Up @@ -653,7 +653,7 @@ protected async Task HandleSetExceptionBreakpointsRequest(
RequestContext<object> requestContext)
{
// TODO: When support for exception breakpoints (unhandled and/or first chance)
// are added to the PowerShell engine, wire up the VSCode exception
// are added to the PowerShell engine, wire up the VSCode exception
// breakpoints here using the pattern below to prevent bug regressions.
//if (!this.noDebug)
//{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public void Update(
logger.Write(LogLevel.Verbose, $"Using Script Analyzer settings path - '{settingsPath ?? ""}'.");
}
catch (Exception ex) when (
ex is NotSupportedException ||
ex is NotSupportedException ||
ex is PathTooLongException ||
ex is SecurityException)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<PropertyGroup>
<AssemblyTitle>PowerShell Editor Services, Visual Studio Code Extensions</AssemblyTitle>
<Description>Provides added functionality to PowerShell Editor Services for the Visual Studio Code editor.</Description>
<TargetFrameworks>net451;netstandard1.6</TargetFrameworks>
<TargetFrameworks>netstandard1.6;net451</TargetFrameworks>
<AssemblyName>Microsoft.PowerShell.EditorServices.VSCode</AssemblyName>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices/Analysis/AnalysisService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public string SettingsPath
/// Creates an instance of the AnalysisService class.
/// </summary>
/// <param name="settingsPath">Path to a PSScriptAnalyzer settings file.</param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">A logger used for writing log messages.</param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well revert all these comment changes. That removes ~25 more files from the PR. :-)

public AnalysisService(string settingsPath, ILogger logger)
{
this._logger = logger;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public abstract class FeatureComponentBase<TProvider>
public IFeatureProviderCollection<TProvider> Providers { get; private set; }

/// <summary>
/// Gets the ILogger implementation to use for writing log
/// Gets the logger to use for writing log
/// messages.
/// </summary>
protected ILogger Logger { get; private set; }
Expand All @@ -36,7 +36,7 @@ public abstract class FeatureComponentBase<TProvider>
/// Creates an instance of the FeatureComponentBase class with
/// the specified ILoggger.
/// </summary>
/// <param name="logger">The ILogger to use for this instance.</param>
/// <param name="logger">The logger to use for this instance.</param>
public FeatureComponentBase(ILogger logger)
{
this.Providers = new FeatureProviderCollection<TProvider>();
Expand Down
4 changes: 2 additions & 2 deletions src/PowerShellEditorServices/Console/ChoicePromptHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ public abstract class ChoicePromptHandler : PromptHandler
#endregion

/// <summary>
///
///
/// </summary>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">A logger used for writing log messages.</param>
public ChoicePromptHandler(ILogger logger) : base(logger)
{
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public abstract class ConsoleChoicePromptHandler : ChoicePromptHandler
/// The IHostOutput implementation to use for writing to the
/// console.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">A logger used for writing log messages.</param>
public ConsoleChoicePromptHandler(
IHostOutput hostOutput,
ILogger logger)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public abstract class ConsoleInputPromptHandler : InputPromptHandler
/// The IHostOutput implementation to use for writing to the
/// console.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">A logger used for writing log messages.</param>
public ConsoleInputPromptHandler(
IHostOutput hostOutput,
ILogger logger)
Expand Down
4 changes: 2 additions & 2 deletions src/PowerShellEditorServices/Console/InputPromptHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ public abstract class InputPromptHandler : PromptHandler
#endregion

/// <summary>
///
///
/// </summary>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public InputPromptHandler(ILogger logger) : base(logger)
{
}
Expand Down
6 changes: 3 additions & 3 deletions src/PowerShellEditorServices/Console/PromptHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ namespace Microsoft.PowerShell.EditorServices.Console
public abstract class PromptHandler
{
/// <summary>
/// Gets the ILogger used for this instance.
/// Gets the logger used for this instance.
/// </summary>
protected ILogger Logger { get; private set; }

/// <summary>
///
///
/// </summary>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public PromptHandler(ILogger logger)
{
this.Logger = logger;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ internal class TerminalChoicePromptHandler : ConsoleChoicePromptHandler
/// The IHostOutput implementation to use for writing to the
/// console.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public TerminalChoicePromptHandler(
ConsoleReadLine consoleReadLine,
IHostOutput hostOutput,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal class TerminalInputPromptHandler : ConsoleInputPromptHandler
/// The IHostOutput implementation to use for writing to the
/// console.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public TerminalInputPromptHandler(
ConsoleReadLine consoleReadLine,
IHostOutput hostOutput,
Expand Down
4 changes: 2 additions & 2 deletions src/PowerShellEditorServices/Debugging/DebugService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public class DebugService
/// <param name="powerShellContext">
/// The PowerShellContext to use for all debugging operations.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public DebugService(PowerShellContext powerShellContext, ILogger logger)
: this(powerShellContext, null, logger)
{
Expand All @@ -96,7 +96,7 @@ public DebugService(PowerShellContext powerShellContext, ILogger logger)
/// <param name="remoteFileManager">
/// A RemoteFileManager instance to use for accessing files in remote sessions.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public DebugService(
PowerShellContext powerShellContext,
RemoteFileManager remoteFileManager,
Expand Down
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices/Language/AstOperations.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ internal static class AstOperations
/// <param name="powerShellContext">
/// The PowerShellContext to use for gathering completions.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
/// <param name="cancellationToken">
/// A CancellationToken to cancel completion requests.
/// </param>
Expand Down
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices/Language/LanguageService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public class LanguageService
/// <param name="powerShellContext">
/// The PowerShellContext in which language service operations will be executed.
/// </param>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public LanguageService(
PowerShellContext powerShellContext,
ILogger logger)
Expand Down
6 changes: 5 additions & 1 deletion src/PowerShellEditorServices/PowerShellEditorServices.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<AssemblyTitle>PowerShell Editor Services</AssemblyTitle>
<Description>Provides common PowerShell editor capabilities as a .NET library.</Description>
<TargetFrameworks>net451;netstandard1.6</TargetFrameworks>
<TargetFrameworks>netstandard1.6;net451</TargetFrameworks>
<AssemblyName>Microsoft.PowerShell.EditorServices</AssemblyName>
<PackageTargetFallback Condition=" '$(TargetFramework)' == 'netstandard1.6' ">$(PackageTargetFallback);dnxcore50;portable-net45+win8</PackageTargetFallback>
</PropertyGroup>
Expand Down Expand Up @@ -61,6 +61,10 @@

<ItemGroup>
<PackageReference Include="UnixConsoleEcho" Version="0.1.0" />
<PackageReference Include="Serilog" Version="2.7.1" />
<PackageReference Include="Serilog.Sinks.Console" Version="3.1.1" />
<PackageReference Include="Serilog.Sinks.File" Version="4.0.0" />
<PackageReference Include="Serilog.Sinks.Async" Version="1.2.0" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.6' ">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,4 @@ public static DscBreakpointCapability CheckForCapability(
return capability;
}
}
}
}
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices/Session/EditorSession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public class EditorSession
/// <summary>
///
/// </summary>
/// <param name="logger">An ILogger implementation used for writing log messages.</param>
/// <param name="logger">Logger used for writing log messages.</param>
public EditorSession(ILogger logger)
{
this.logger = logger;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class EditorServicesPSHost : PSHost, IHostSupportsInteractiveSession
/// <param name="hostUserInterface">
/// The EditorServicesPSHostUserInterface implementation to use for this host.
/// </param>
/// <param name="logger">An ILogger implementation to use for this host.</param>
/// <param name="logger">Logger to use for this host.</param>
public EditorServicesPSHost(
PowerShellContext powerShellContext,
HostDetails hostDetails,
Expand Down
Loading