-
Notifications
You must be signed in to change notification settings - Fork 235
Change logging to use Serilog #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 35 commits
6f64497
3781012
535d6c1
4f35fef
9c6dc76
cf5086d
ab9f87f
79d7c6b
c0214df
40c183c
be2f224
2f3b057
c73fd2b
a1e830d
164b4d3
54f169d
1997fba
6dd1c37
acd74f3
3c1c51a
3f316ca
a83e31c
d7bacd9
d8e03c4
bd6cc79
ec3d2a9
fda57ef
46fd4e6
2ce6b9c
e27caff
23cd8ec
d03ee64
9dcaef4
64dd41d
9ecf846
fb7fc0f
54a53bb
e9becd1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,4 +160,4 @@ private class CodeLensData | |
public string ProviderId {get; set; } | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,4 +61,4 @@ public static async Task<TcpSocketClientChannel> Connect( | |
return clientChannel; | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,4 +55,4 @@ protected override void Shutdown() | |
} | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ public IEditorOperations EditorOperations | |
/// <param name="messageHandlers">An object that manages all of the message handlers</param> | ||
/// <param name="messageSender">The message sender</param> | ||
/// <param name="serverCompletedTask">A TaskCompletionSource<bool> that will be completed to stop the running process</param> | ||
/// <param name="logger">The logger</param> | ||
/// <param name="logger">the logger</param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any particular reason for changing the case here? Not a big deal, just curious if this was intentional. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not intentional — the result of changing all the logging doc lines and back again. |
||
public LanguageServer( | ||
EditorSession editorSession, | ||
IMessageHandlers messageHandlers, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -162,4 +162,4 @@ public static DscBreakpointCapability CheckForCapability( | |
return capability; | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the config line to trim trailing whitespace if/when we add a
.editorconfig
file. :-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! I think the
.editorconfig
is a good idea.Do you mean here I should remove the space I added before the brace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, bad example. There were some trailing spaces after a chained exception filter that got removed. That's where the editorconfig file would have helped me where I use VS and it doesn't normally trim trailing whitespace.