Add new client/server API for the host process #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still finishing up this PR, need to clean up a few things and merge Doug's latest PR. @adamdriscoll: Take a look at the changes in src\PowerShellEditorServices.Protocol\MessageProtocol\Channel and see if you think the HTTP/WebSockets implementation could be based on ChannelBase. |
| # Visual Studio 2013 | ||
| VisualStudioVersion = 12.0.40629.0 | ||
| # Visual Studio 14 | ||
| VisualStudioVersion = 14.0.24720.0 |
There was a problem hiding this comment.
Looks like the solution opens in VS 2013 with no complaints, will leave it like this.
daviwil
force-pushed
the
daviwil/client-server-api
branch
2 times, most recently
from
f6e931b to
1706b17
Compare
This change introduces a new set of classes that make it much easier to write a language server or debug adapter and clients for either type of server. All client/server logic has been moved to the Protocol library so that it can be used in other host applications outside of the provided host process.
daviwil
force-pushed
the
daviwil/client-server-api
branch
from
1706b17 to
8fbd01c
Compare
This change adds a couple lines to appveyor.yml that can be used to enable RDP access to the build server when something goes wrong. To use this configuration, the developer must uncomment the two lines and make another commit to their PR branch. Details are included in the config file.
daviwil
force-pushed
the
daviwil/client-server-api
branch
from
ec7fd00 to
9c90e98
Compare
This change adds a new /logPath parameter to the host process which is used to provide unique log paths for host process tests. These new log paths will help diagnose issues with individual tests, especially when running on AppVeyor.
daviwil
force-pushed
the
daviwil/client-server-api
branch
2 times, most recently
from
74e38c0 to
29a560f
Compare
|
After fighting with test failures all day, finally merging this! |
daviwil
added a commit
that referenced
this pull request
Dec 11, 2015
Add new client/server API for the host process
|
Sweet! Looks great! |
|
Thanks! I'll finally get NuGet packages posted sometime next week :) Until then you might be able to get by with hacking in the host process while you're writing your new channel implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes introduces a new client/server API which makes it much easier to create a language server or debug adapter implementation with matching C# client. It also abstracts a "channel" model which enables different transport channels to be used with this client/server API. For now only the standard I/O channel is implemented but other channels could easily be added.