Eliminate duplicate dgb prompt #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
approved these changes
Feb 21, 2018
| // Add the [DBG] prefix if we're stopped in the debugger | ||
| if (this.powerShellContext.IsDebuggerStopped) | ||
| // Add the [DBG] prefix if we're stopped in the debugger and the prompt doesn't already have [DBG] in it | ||
| if (this.powerShellContext.IsDebuggerStopped && !promptString.Contains("[DBG]")) |
There was a problem hiding this comment.
Do we need the check at all or could we just remove the "add DBG to string" logic entirely?
There was a problem hiding this comment.
I think we could improve the current logic but a PowerShell host typically does add [DBG]: to the beginning of the prompt during debug. However, PowerShell.exe will not do this if it has detected the user has a custom prompt function. For now, I think this is reasonable - avoid duplicate [DBG] in the prompt string.
daviwil
approved these changes
Feb 21, 2018
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
…tion Add right-click context menu for Run Selection command
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to eliminate duplicate
[DBG]in the prompt string for folks like me that write their prompt function to handle the DBG prompt. Without this change, my prompt looks like this:And after this change: