Track tempIntegratedConsole launch param, do not exit when session ends #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -303,6 +303,12 @@ private void OnDebugServiceClientConnect(object sender, TcpSocketServerChannel s | |||
|
|
|||
| this.debugServiceListener.Start(); | |||
| } | |||
| else if (this.debugAdapter.IsUsingTempIntegratedConsole) | |||
There was a problem hiding this comment.
So this else if prevents the host from exiting... What's the host in this case?
More simply, what is the user experience change?
There was a problem hiding this comment.
The temp debug console does not immediately exit after the script finishes execution or the debug session is stopped. This allows the user to scroll through the window to inspect the script output.
The only downside I've observed at this point is that every temp debug session log file ends with:
2/19/2018 8:48:16 PM [ERROR] - Method "ListenForMessages" at line 344 of C:\Users\Keith\GitHub\rkeithhill\PowerShellEditorServices\src\PowerShellEditorServices.Protocol\MessageProtocol\ProtocolEndpoint.cs
Stream terminated unexpectedly, ending MessageDispatcher loop
Exception: IOException
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host.
This is because VSCode does terminate the process when it starts the next debug session. All things considered, I think this is a fine trade-off.
TylerLeonhardt
approved these changes
Feb 20, 2018
daviwil
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not leave a working prompt. I think that is OK for now. This is still better than the current situation.