replace sort with sort-object #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
daviwil,
rkeithhill and
SeeminglyScience
rkeithhill
approved these changes
Feb 3, 2018
There was a problem hiding this comment.
The sort alias is not created on Linux (and apparently macOS) because there is a built-in sort utility that can't deal with PowerShell pipeline objects. So yeah, Sort-Object is what we want. We need to make sure we don't use any aliases in PS script - even the script embedded in our C# code.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
This change adds new behavior which causes VS Code's debugger UI to be activated when a breakpoint is hit in the Integrated Console while not currently in debug mode. This allows the user to set breakpoints and run scripts from the console while still leveraging VS Code's rich debugging UI. Resolves PowerShell#619.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, on macOS
Sortdid not exist.I switched it to Sort-Object which is universal and not an alias.
It's a shame we can't run PSSA on our script strings in the c# of PSES :) No aliases allowed!
Resolves PowerShell/vscode-powershell#1185