Skip to content

change Enumerate* to Get* #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2018
Merged

change Enumerate* to Get* #616

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107ca20
change Enumerate* to Get*
TylerLeonhardt Jan 22, 2018
09cbdaa
catch all the exceptions
TylerLeonhardt Jan 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/PowerShellEditorServices/Workspace/Workspace.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,22 @@ private IEnumerable<string> RecursivelyEnumerateFiles(string folderPath)
folderPath,
pattern));
}
catch (UnauthorizedAccessException e)
catch (DirectoryNotFoundException e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

{
this.logger.WriteException(
$"Could not enumerate files in the path '{folderPath}' due to a file not being accessible",
$"Could not enumerate files in the path '{folderPath}' due to a path being an invalid path",
e);
}
catch (PathTooLongException e)
{
this.logger.WriteException(
$"Could not enumerate files in the path '{folderPath}' due to a path being too long",
e);
}
catch (Exception e) when (e is SecurityException || e is UnauthorizedAccessException)
{
this.logger.WriteException(
$"Could not enumerate files in the path '{folderPath}' due to a path not being accessible",
e);
}
}
Expand Down