copy third party notices to module folder at build time #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do it because some of the files there ( For now we just add specific entries to .gitignore to avoid having these things checked in. I'd add the Third Party Notices file under modules path to .gitignore: https://github.com/PowerShell/PowerShellEditorServices/blob/master/.gitignore#L30 |
|
Ohhhhhhh that makes a lot of sense then. I didn't realize those weren't generated. Cool! |
daviwil
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you build, it will copy the Third Party Notices.txt into the module folder for when we distribute the extension.
I don't really like that the module folder gets checked in to the repro (Any reason why we do that?) since it's generated at build time, but I'm considering that out of scope for now which is why the Third Party Notices is in this PR too.