Create Third Party Notices.txt #603
Conversation
|
@daviwil is that done in an automated way somewhere? |
|
Yep, that works |
|
|
||
| UnixConsoleEcho | ||
|
|
||
| Copyright (c) 2017 Patrick Meinecke |
There was a problem hiding this comment.
Shouldn't this be 2018 or at least 2017-2018? :-)
There was a problem hiding this comment.
I don't think you need to specify a range, copyright automatically extends quite a few years after initial creation :)
There was a problem hiding this comment.
Fair enough. Also, I've been told by our legal department that Copyright (c) is redundant. You only need one of: Copyright or (c) or ©. RE ranges and copyright update, I was told it should be updated whenever the associated source file (or copyrighted artifact) is updated so in our older code-base you see a combination of comma separate years and ranges. Because of the "copyright extends past the last date for some (large) number of years" we got our legal dept to buy off on us not putting copyright years in our source code. It got to be too much of a PITA to keep it correct and besides, devs often forget to update copyright notices in source code anyway. :-)
There was a problem hiding this comment.
Pretty sure he was just copying my notice :P
If it makes anything easier I can just remove the copyright from the license. Pretty sure it was just a part of whatever template I copied it from :)
Either way I can guarantee I'll never update it :P
|
|
||
| UnixConsoleEcho | ||
|
|
||
| Copyright (c) 2017 Patrick Meinecke |
There was a problem hiding this comment.
Fair enough. Also, I've been told by our legal department that Copyright (c) is redundant. You only need one of: Copyright or (c) or ©. RE ranges and copyright update, I was told it should be updated whenever the associated source file (or copyrighted artifact) is updated so in our older code-base you see a combination of comma separate years and ranges. Because of the "copyright extends past the last date for some (large) number of years" we got our legal dept to buy off on us not putting copyright years in our source code. It got to be too much of a PITA to keep it correct and besides, devs often forget to update copyright notices in source code anyway. :-)
|
It's fine. Copyright notices get me going having gone a few rounds with our legal folks. Go ahead and merge it. |
…owerShell#1281) Fix PowerShell#603 where system has ipv6 addresses disabled. This is also more consistent with the PSES TCP listener which always [IPAddress]::Loopback as the IP address.
For legal purposes.
for reference: https://github.com/PowerShell/vscode-powershell/blob/master/Third%20Party%20Notices.txt