Catch ArgumentOutOfRange exception #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
approved these changes
Dec 6, 2017
daviwil
reviewed
Dec 6, 2017
| } | ||
| catch (ArgumentOutOfRangeException e) | ||
| { | ||
| scriptExtentText = ""; |
There was a problem hiding this comment.
One general "best practice" in C# is when you need to use an empty string, use string.Empty instead of "". I think it might save an allocation, but it's not that big of a deal if you don't do it.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
This change enables the saving of files opened from a remote session using the psedit command. When the editor saves the file contents it sends a DidSaveTextDocumentNotification to the language server which in turn sends the document's contents back to the remote session to be saved in the original file. Resolves PowerShell#583.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #582
IScriptExtentthrows anArgumentOutOfRangeException. When accessing theTextproperty.This PR catches that error and sets it to a default value of empty string.