Fix crash of PSES on startup when workspace folder has [] in path #580
Conversation
…r has wildard chars [] in path
|
Is there a place this method is being called where we would pass true for that parameter? If not, maybe just make path escaping be the default behavior? |
|
@daviwil Not in our code base. I almost made the path escaping the default but the API is public and that would have been a breaking change. That said, I'm not sure we have any external users yet, other than maybe @adamdriscoll. What do you think? Should I escape by default and leave the second overload for anyone who doesn't want the path escaped (i.e. for when the path is already escaped). |
|
I don't think anyone external would be using it, but I agree that maybe we should retain the current behavior by default until we make a 2.0 of the .NET APIs. I'd say leave it how you've got it for now. |
|
Is there a way to implement this into 1.5.1 rather than waiting for the release? This is a big thing for me. |
|
You could build your own version of PSES and copy it over the one that comes with the extension. Or I could provide you with a ZIP of the assemblies with this fix. |
This change adds two new settings to control the automatic loading of the PowerShell extension and integrated console: - `powershell.startAutomatically` - `powershell.integratedConsole.showOnStartup` Both of which default to `true`. Resolves PowerShell#580.
This fixes PowerShell/vscode-powershell#1014