Do not set breakpoint on non-PowerShell files #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
reviewed
Nov 8, 2017
| @@ -490,7 +490,12 @@ protected void Stop() | |||
| // VSCode sends breakpoint requests with the original filename that doesn't exist anymore. | |||
| try | |||
| { | |||
| scriptFile = editorSession.Workspace.GetFile(setBreakpointsParams.Source.Path); | |||
| // When you set a breakpoint in the right pane of a Git diff window on a PS1 file, | |||
There was a problem hiding this comment.
Since we're checking for this prefix in another place, maybe it's time to pull this out into a helper method?
|
Good idea. Any suggestions on where this centralized check should be? |
daviwil
approved these changes
Nov 8, 2017
|
BTW I'm pretty sure the test errors are because we set line breakpoints in tests with a filename of |
|
I think you could add a static method to ScriptFile for that. Ouch, we shouldn't be sending empty strings for paths in those tests... |
|
Yeah, that was probably me ... those chickens have come home to roost. :-/ I will try to finish this PR up tonight - add that static method. |
|
OMG, the Travis build is taking forever to start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #574
There's still an associated but separate bug when a user is attempting to start debug on the current file when the active window is a Git diff window. I opened an issue on vscode-debugadpter-node project: microsoft/vscode-debugadapter-node#134