Fix stack trace so it shows external code as "deemphasized". #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
approved these changes
Jul 6, 2017
| /// <summary> | ||
| /// Displays the stack frame in a subtle way, typically used from loctaions outside of the current project or workspace. | ||
| /// </summary> | ||
| Subtle |
There was a problem hiding this comment.
Should this be Deemphasize too or are they inconsistent?
There was a problem hiding this comment.
Weird as it seems, the PresentationHint on StackFrame has different values than the PresentationHint on Source. https://github.com/Microsoft/vscode-debugadapter-node/blob/master/protocol/src/debugProtocol.ts#L1131
That accounts for part of the confusion I was running into. And then there was also the typo in the VSCode impl. But this works with 1.13.1 so yay!
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Release 0.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.