Introduce the new provider model with CodeLens and document symbol providers #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new interface called IComponentRegistry which acts as a dependency container for components in PowerShell Editor Services. It also adds a default ComponentRegistry class which implements this interface so that it can be used in the server.
This change introduces a new provider model into PowerShell Editor Services so that feature components can have an arbitrary number of providers registered which are used in addition to any default implementations. This is intended to be used as an extensibility mechanism.
This change adds the IDocumentSymbols and IDocumentSymbolProvider interfaces plus their implementations, moving the existing symbol provider classes over to this new model.
This change adds the ICodeLenses and ICodeLensProvider interfaces and their implementations to establish the provider model for CodeLenses in the editor.
This name change will help the purpose of this design to be more obvious and also distinguish it from other PowerShell features that are called "providers."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This establishes the new IFeatureProvider model and the IComponentRegistry interface which allows us to have a highly composable feature design enabling external modules to plug in new behavior to existing feature interfaces.
Please feel free to ask any questions you have about what I've done here, I won't be merging the code until the morning.