Errors and output written during profile loading don't show in host #454
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes both errors and object output to be written to the host when profiles are being loaded. Users who had issues in their profile scripts thought that the scripts weren't being loaded when in fact there were errors not being displayed. Also, users using Write-Output in their profile scripts did not see that output. This change makes the PSES host consistent with the PowerShell ConsoleHost, writing both forms of output when loading profile scripts. Resolves PowerShell/vscode-powershell#689 Resolves PowerShell/vscode-powershell#663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes both errors and object output to be written to the
host when profiles are being loaded. Users who had issues in their
profile scripts thought that the scripts weren't being loaded when in
fact there were errors not being displayed. Also, users using
Write-Output in their profile scripts did not see that output. This
change makes the PSES host consistent with the PowerShell ConsoleHost,
writing both forms of output when loading profile scripts.
Resolves PowerShell/vscode-powershell#689
Resolves PowerShell/vscode-powershell#663