Remove extra prompt string added to interactive debugging session #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes some code that was causing an extra command prompt string to be printed to the integrated console when running an interactive debugging session. It also makes the termination of such a session more reliable. Resolves PowerShell#422.
rkeithhill
reviewed
Apr 6, 2017
| { | ||
| await this.editorSession.PowerShellContext.ExecuteScriptString( | ||
| "", false, true); | ||
| } |
There was a problem hiding this comment.
So what do we miss out on during an interactive session debug by not having the above code? An initial prompt string?
There was a problem hiding this comment.
The prompt has already been written by this point, so this line is totally pointless now. It was necessary before the integrated console came along because a prompt was never displayed at first when the debugger starts, the assumption was that we were launching a script. For an "interactive session" I needed to invoke a prompt to display, so this was a hacky way to do that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes some code that was causing an extra command prompt
string to be printed to the integrated console when running an
interactive debugging session. It also makes the termination of such a
session more reliable.
Resolves #422.