Fix #346: GetVersionDetails failing due to empty environment variable #347
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue caused by a recent change in the VS Code extension which wiped out all of the environment variables in the process. That particular issue has now been fixed but it's still good to guard against this problem in the future. This change adds a null check to ensure that we don't throw a NullReferenceException in future occurrences of the issue.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue caused by a recent change in the VS Code
extension which wiped out all of the environment variables in the process.
That particular issue has now been fixed but it's still good to guard
against this problem in the future. This change adds a null check to
ensure that we don't throw a NullReferenceException in future occurrences
of the issue.