Handle non-string return values from the user's prompt function #344
+66
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a catch for the InvalidCastException when gathering the user's prompt string in the case where their prompt function returns a value other than a string. In this case a default prompt is returned. This change also improves the way we write prompts for the debugger. Instead of writing out the prompt each time the debugger stops, we write out the details about the breakpoint that was hit, if any. We also try to preserve any session context at the beginning of the prompt string like the remote computer name or process ID. Fixes #339.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Add quickfix functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a catch for the InvalidCastException when gathering the
user's prompt string in the case where their prompt function returns a
value other than a string. In this case a default prompt is returned.
This change also improves the way we write prompts for the debugger.
Instead of writing out the prompt each time the debugger stops, we write
out the details about the breakpoint that was hit, if any. We also try to
preserve any session context at the beginning of the prompt string like
the remote computer name or process ID.
Fixes #339.