Prevent concurrent commands in analysis services #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daviwil Can you please verify this on your side too. I am not able to reproduce PowerShell/vscode-powershell#400 consistently on my PC. By the time I open the PSSA rules menu PSES is already initialized, but sometimes I can get lucky to get the session termination error. |
|
Just tried this out, works fine for me! I added a 5 second thread sleep after the diagnostic records were returned so that I can emulate a long delay. While it was sleeping, I tried to get the PSSA rules using the menu. The menu didn't appear until after the diagnostics got sent back to the editor. Looks good. |
|
Thanks @daviwil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.