Fix #325: Module dependency loading should pick latest module version #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue with the loading of both the PSScriptAnalyzer and Plaster modules. We were simply using Import-Module without specifying a version to be loaded. Apparently PowerShell prioritizes the PSModulePath order over the module version order so there are instances where an older version of one of these module will be loaded even though a newer version is available at a different location on the machine. This change adds extra logic to sort the list of returned modules so that the latest version of the module is always loaded.
|
@rkeithhill any comments or concerns about this manner of loading the latest version of our dependency modules? Within the next couple of "major" releases I'm going to add a "ModuleService" that will allow us to go a little further and ask for a version of the module within a specified range so that we won't pick up major version bumps. |
rkeithhill
approved these changes
Dec 19, 2016
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with the loading of both the PSScriptAnalyzer
and Plaster modules. We were simply using Import-Module without
specifying a version to be loaded. Apparently PowerShell prioritizes the
PSModulePath order over the module version order so there are instances
where an older version of one of these module will be loaded even though a
newer version is available at a different location on the machine.
This change adds extra logic to sort the list of returned modules so that
the latest version of the module is always loaded.